Fix issue #6181: Added feature Azure Key Vault#126
Open
TheVidz wants to merge 2 commits intojuspay:mainfrom
Open
Fix issue #6181: Added feature Azure Key Vault#126TheVidz wants to merge 2 commits intojuspay:mainfrom
TheVidz wants to merge 2 commits intojuspay:mainfrom
Conversation
Chethan-rao
suggested changes
Oct 10, 2024
Contributor
Chethan-rao
left a comment
Chethan-rao
left a comment
There was a problem hiding this comment.
Hi @TheVidz,
Thank you for the PR and congrats on your first pull request to hyperswitch-card-vault. Have left some comments. please address.
Also please test the feature and add screen shots of test cases in the PR description.
Co-authored-by: Chethan Rao <70657455+Chethan-rao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request to hyperswitch-card-vault under Hacktoberfest, kindly give feedback and review.
Support for Azure Key Vault added for Secrets manager similar to the available AWS KMS, HashiCorp Vault, plaintext.
Closes issue #6181
Created files:
Thank you!