feat(error): handle json error as json instead of plaintext#125
Open
NishantJoshi00 wants to merge 1 commit intomainfrom
Open
feat(error): handle json error as json instead of plaintext#125NishantJoshi00 wants to merge 1 commit intomainfrom
NishantJoshi00 wants to merge 1 commit intomainfrom
Conversation
Chethan-rao
approved these changes
Oct 4, 2024
ShankarSinghC
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several updates primarily focused on refactoring the use of the
axumlibrary and improving error handling. The most important changes include adding new dependencies, modifying error handling withJsonError, and updating various route handlers to use the newJsontype.Dependency Updates:
Cargo.toml: Addedaxum-extraand modifiedaxumto include themacrosfeature.Error Handling Improvements:
src/error.rs: IntroducedJsonErrorstruct and implementedFrom<JsonRejection>andIntoResponsefor better error handling.src/middleware.rs: Updated middleware to useerror::Jsonfor JSON extraction.Route Handler Updates:
src/routes/data.rs: Refactored multiple route handlers (add_card,delete_card,retrieve_card,get_or_insert_fingerprint) to useerror::Jsonfor request extraction andaxum::Jsonfor responses. [1] [2] [3] [4]src/routes/health.rs: Updated health check handlers to useaxum::Jsonfor responses. [1] [2]src/routes/key_custodian.rs: Refactored key custodian route handlers (key1,key2,decrypt) to useerror::Jsonfor request extraction andaxum::Jsonfor responses. [1] [2] [3] [4]src/routes/key_migration.rs: Updatedtransfer_keyshandler to useerror::Jsonfor request extraction andaxum::Jsonfor responses. [1] [2]