-
Notifications
You must be signed in to change notification settings - Fork 23
GHC 927 upgrade #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arjunkathuria
wants to merge
13
commits into
juspay:ag/open-source
Choose a base branch
from
arjunkathuria:Mobility-GHC927
base: ag/open-source
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GHC 927 upgrade #10
arjunkathuria
wants to merge
13
commits into
juspay:ag/open-source
from
arjunkathuria:Mobility-GHC927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* marshall or convert between some types where necessary * provide type-hints where necessary
* Mirgrate from old Aeson < 1.5 syntax to new Aeson > 2.0.1 syntax * Marshall types and functions as required
* Remove version bounds (to be taken from stack) * Adds warning for ambiguous fields instead of being a build error
* Removes deprecated function imports from Euler-hs from test-suite
* Newer version of Upstram Beam library demands that we use fixed sized integer types like "Int64" or "Int32", instead of the machine-dependent Integer type "Int" * Make changes to test-suite that fix & reflect the above requirement.
* The order of key-fields of a few encoded JSON bytestrings needed to be shuffled around a little in the test-suite. * It now expects fields be in alphabetical order after all the updates (probably Aeson in particular), i think.
* makes some build-errors warnings instead in some source files * These build-errors prevented the project to build with GHC 9.2.5 * They can be turned into warnings for now (since the code has always been this way) The new GHC update just started treating them as build-errors. * These can be dealt with in a new iteration later.
* There was a parse-error in cabal.project file with haskell-flake i think. * Added a new line, since thats what the parser expects and it is identically the same as before.
* Adds ".envrc" file the enables using direnv to load the flake environment * Use "direnv allow" to activate it as usual
* Updates .gitignore file to ignore .direnv and result folder.
* Adds flake.nix with nix setup ready to build Euler-hs with GHC-9.2.7 * flake.nix uses the newer haskell-flake 0.4.0 (unreleased) syntax , by way of common repo * Adds the corresponding flake.lock file
Author
|
cc: @aravindgopall |
8 tasks
Member
|
@arjunkathuria Why is this PR not targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables and upgrades Euler-hs repo to be able build with newer GHC 9.2.7, using nix.
Key changes include
and more.