Conversation
deigote
commented
Jun 4, 2013
deigote
commented
- The class maintenance gets easier since you can parametrize the java version and the tarball name, so new releases are not needed when a new java version is available
- The path where the original tarball can be found can also be passed as a parameter, so people who don't want to put it in the module itself have an alternative
- Sensible defaults (aka the ones that were hardcoded before) so backward compatibility is guaranteed
…dated with each java version and also for allowing the original tarball to not be in the module directory
…seems to be optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.