Skip to content

Remove check for loadDynamicLibrary method #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 1 commit into from
Mar 27, 2026
Merged

Remove check for loadDynamicLibrary method #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/xeus/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,7 @@ export abstract class EmpackedXeusRemoteKernel extends XeusRemoteKernelBase {
pkgRootUrl: this._pkgRootUrl
});

if (
this.Module.FS === undefined ||
this.Module.loadDynamicLibrary === undefined
) {
if (this.Module.FS === undefined) {
console.warn(
`Cannot initialize the file-system of ${kernelSpec.dir} since it wasn't compiled with FS support.`
);
Expand Down Expand Up @@ -144,10 +141,7 @@ export abstract class EmpackedXeusRemoteKernel extends XeusRemoteKernelBase {
protected async initializeInterpreter(
options: IEmpackXeusWorkerKernel.IOptions
) {
if (
this.Module.FS === undefined ||
this.Module.loadDynamicLibrary === undefined
) {
if (this.Module.FS === undefined) {
// Return early, we've already warned earlier
return;
}
Expand Down
Loading