Merged
Conversation
There are no real UI-tests yet so let's make it dumb so that it's green
Member
|
Maybe the UI tests should be added to the kernel repos directly now? Some UI tests might be generic, such as this one: jupyterlite/xeus-python-kernel#175 Others more specific to each kernel, for example: jupyterlite/xeus-python-kernel#187 |
Member
Author
|
Maybe a tiny test here would be useful, maybe using a fake kernel if we can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no real UI-tests yet so let's make it dumb so that it's green for now