Add support for images and pdf files#306
Open
Yahiewi wants to merge 1 commit intojupyterlite:mainfrom
Open
Conversation
Contributor
Author
|
GIFs are not/only partially supported by all AIs as input. Claude, for example can see them as still images, Mistral however produces an 'Error generating response' with the following console log: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #292 by fixing the way attachments are read and sent to the AI.
Main code changes:
sendMessagefunction,enhancedMessageis now declared asUserContentandattachmentContentsis now replaced by{ textContents, binaryParts }_processAttachmentsreturn signature changed fromPromise<string[]>toPromise<{ textContents: string[] binaryParts: Array<ImagePart | FilePart>}>and replacedconst contentswithtextContents: string[]andbinaryParts : Array<ImagePart | FilePart>-
imageMimeTypes: .png, .jpg, .jpeg, .gif, .webp, .bmp (which is sent as ImagePart)-
fileMimeTypes: .pdf (which is sent as FilePart)Screencast.from.2026-04-02.10-51-56.mp4