This repository was archived by the owner on Mar 2, 2020. It is now read-only.
Open
Conversation
junkerm
suggested changes
Jun 21, 2019
Owner
junkerm
left a comment
junkerm
left a comment
There was a problem hiding this comment.
Works! A few remarks below. We should think about what we do with the field in the eiditor view, Will it be removed or will we put the same functionality there too?
| @@ -0,0 +1,17 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Owner
There was a problem hiding this comment.
please remove this whole project
| } | ||
| desc = desc.trim(); | ||
|
|
||
| if (desc.length <= 3) { |
Owner
There was a problem hiding this comment.
Would it make sense to set this to 4? This means as soon as someone types the whole word "WENN" the font is changed.
Also you could make the code much more simple by just doing description.startsWith(this.objectifIndicator)
|
|
||
| if (this.modelDescription.length > 0) { | ||
| element.modelRequirements = this.modelDescription; | ||
| if (description.length > 0) { |
Owner
There was a problem hiding this comment.
please comment on what is happening here or better, create a separate method with a speaking name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requirement input field switches to a monospaced font, when the user types objectif code.