Utilize XPRSoptimize, and avoid deprecated funcs #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted function calls for version 44.01.
joaquimg
reviewed
Jan 15, 2025
| elseif is_mip(model) | ||
| @checked Lib.XPRSmipoptimize(model.inner, model.solve_method) | ||
|
|
||
| version = getversion() |
Member
There was a problem hiding this comment.
This is absolutely zero overhead?
Xpress sometimes is impressively slow for very simple things.
If no we could run this on initialization and save in a const.
Author
There was a problem hiding this comment.
@btime Xpress.getversion()
715.517 ns (11 allocations: 1.64 KiB)
v"44.1.1"
Does not seem to be a significant overhead.
|
|
||
| # XPRSgetnlpsol and XPRSgetmippsol are deprecated as of version 44.01 | ||
| # XPRSgetsolution is also recommended instead of XPRSgetlpsol also after solving LPs | ||
| if version >= v"44.01" |
Member
There was a problem hiding this comment.
Were you very careful selecting this and the other version?
Author
There was a problem hiding this comment.
Deprecations are given with version in xpress.h. For example
XPRS_EXPORT
xprs_deprecated("since 44.00")
int XPRS_CC XPRSgetnlpsol(XPRSprob prob, double x[], double slack[], double duals[], double djs[]);
As for the introduction of XPRSoptimize, I have checked that it is present in v41 (Xpress 9.0) and not in v40 (Xpress 8.14.x).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problems referred to in #274. This will allow more recent versions of Xpress to use correct algorithms based on internal analysis (which is needed e.g. to solve non-convex quadratic problems with the nonlinear solver). It also replaces some deprecated calls with the recommended solutions for the most recent versions of Xpress.