Skip to content

Use CanonicalVector from MOI #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 2 commits into from
Jul 28, 2025
Merged

Use CanonicalVector from MOI #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
315396c
Use CanonicalVector from MOI
blegat Jul 28, 2025
7267d04
Remove tests
blegat Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 1 addition & 40 deletions src/dual_equality_constraints.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,47 +498,8 @@ function _fill_scalar_affine_terms!(
return
end

struct _CanonicalVector{T} <: AbstractVector{T}
index::Int
n::Int
end

Base.eltype(::Type{_CanonicalVector{T}}) where {T} = T

Base.length(v::_CanonicalVector) = v.n

Base.size(v::_CanonicalVector) = (v.n,)

function Base.getindex(v::_CanonicalVector{T}, i::Integer) where {T}
return convert(T, i == v.index)
end

# This is much faster than the default implementation that goes
# through all entries even if only one is nonzero.
function LinearAlgebra.dot(
x::_CanonicalVector{T},
y::_CanonicalVector{T},
) where {T}
return convert(T, x.index == y.index)
end

function MOI.Utilities.triangle_dot(
x::_CanonicalVector{T},
y::_CanonicalVector{T},
dim::Int,
offset::Int,
) where {T}
if x.index != y.index || x.index <= offset
return zero(T)
elseif MOI.Utilities.is_diagonal_vectorized_index(x.index - offset)
return one(T)
else
return 2one(T)
end
end

function set_dot(i::Integer, s::MOI.AbstractVectorSet, T::Type)
vec = _CanonicalVector{T}(i, MOI.dimension(s))
vec = MOI.Utilities.CanonicalVector{T}(i, MOI.dimension(s))
return MOI.Utilities.set_dot(vec, vec, s)
end

Expand Down
32 changes: 0 additions & 32 deletions test/Tests/test_dot.jl
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ include("Tests/test_dualize_exponential.jl")
include("Tests/test_dualize_power.jl")
include("Tests/test_dualize_quadratic.jl")
include("Tests/test_dual_names.jl")
include("Tests/test_dot.jl")

include("Tests/test_partial_dual_linear.jl")
include("Tests/test_partial_dual_quadratic.jl")
Expand Down