Smash the UniversalScanner project as a library and desktop application. #3
Conversation
julienblitte
left a comment
julienblitte
left a comment
There was a problem hiding this comment.
Thanks for you interest and your pull request.
I am afraid, I am not planning for now to have gRPC service for a such small tool.
Also, I would like to include Packages or change dotNet version (for compatibility issues on other tools) and rename source file (as we will lose file tracking in github).
| <configuration> | ||
| <startup> | ||
| <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" /> | ||
| <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2"/> |
There was a problem hiding this comment.
Please do not change framework version, this has been setup to be compliant with other software component with same version (which does not appear publicly)
| <RootNamespace>UniversalScanner</RootNamespace> | ||
| <AssemblyName>UniversalScanner</AssemblyName> | ||
| <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion> | ||
| <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion> |
There was a problem hiding this comment.
Please do not change framework version, this has been setup to be compliant with other software component with same version (which does not appear publicly)
| .vs | ||
| bin | ||
| obj | ||
| ## Ignore Visual Studio temporary files, build results, and |
There was a problem hiding this comment.
Is this .gitignore auto-generated?
Do you really need to ignore all this files? Is it because of your environment?
| </Reference> | ||
| <Reference Include="System" /> | ||
| <Reference Include="System.Core" /> | ||
| <Reference Include="System.Security.AccessControl, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> |
There was a problem hiding this comment.
I would like to avoid extra packages or .dll file, please kindly remove this inclusion if not necessary.
I necessary, please kindly expand why.
| <HintPath>..\packages\System.Security.AccessControl.4.7.0\lib\net461\System.Security.AccessControl.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="System.Security.Principal.Windows, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> | ||
| <HintPath>..\packages\System.Security.Principal.Windows.4.7.0\lib\net461\System.Security.Principal.Windows.dll</HintPath> |
There was a problem hiding this comment.
I would like to avoid extra packages or .dll file, please kindly remove this inclusion if not necessary.
I necessary, please kindly expand why. Is this because of your environment?
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
I would like to have one single running file at launch, as it is a very small and easy tool designed to scan network for device on customer site.
| @@ -0,0 +1,28 @@ | |||
| name: .NET Core | |||
There was a problem hiding this comment.
I am not using Workflow at this point, I do not think this is relevant to have it for such small project.
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "scannerTemplate", "scannerTemplate\scannerTemplate.csproj", "{CA2EBD82-FF40-4A5B-AEC6-D95104D159EF}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "scannerTemplate", "scannerTemplate\scannerTemplate.csproj", "{32E255E4-8C44-470F-911A-E29729DCFA8E}" | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UniversalScannerService", "UniversalScannerService\UniversalScannerService.csproj", "{E69C2B74-EDC5-4362-9D7D-AA88C93C24D5}" |
There was a problem hiding this comment.
Sorry, but I do not see added value to split interface and core for such small tool for now.
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
There was a problem hiding this comment.
Please remove packages, I tend to avoid packages to reduce use of external library.
Also, please note the version of dotNet I use is different.
| @@ -0,0 +1,39 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Could you please kindly explain what is the added value to use Grpc on a small tool like this? I am afraid I do not see a real added value here.
2 participants
It is always a good choice to separate the application into layers. The best method to develop modularly would be to separate the common layer and the application layer.