Open
Conversation
juliangruber
requested changes
Dec 16, 2022
Owner
juliangruber
left a comment
juliangruber
left a comment
There was a problem hiding this comment.
Would you mind also updating https://github.com/juliangruber/find-pull-request-action/blob/master/action.yml?
Otherwise, lgtm! :)
| ? res.data.length && | ||
| res.data | ||
| .filter((pr) => pr.user.login === author) | ||
| .filter((pr) => pr.labels.some((lb) => lb.name === label))[0] |
Owner
There was a problem hiding this comment.
This won't find anything if the PR has no labels:
> [].some(() => true)
false
Owner
There was a problem hiding this comment.
But doesn't this mean that this action won't be able to find PRs without labels any more?
Author
There was a problem hiding this comment.
Ah I see what you mean, that's right.
Honestly I switched to actions/github-script as they allow to easily define custom logic so I'm not sure if this action would require additional features implemented. If anyone needs smth more complex they can use actions/github-script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.