-
Notifications
You must be signed in to change notification settings - Fork 0
DataModule Refactoring and Test / Prediction code #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edoardogiacomello
wants to merge
15
commits into
main
Choose a base branch
from
faster_prediction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TODO] Fix device placement for lvae tensors
[Fix] Set logs_every_n_steps to allow alignment across different world_size
[Fix] Radius patience is increased only in semiSL mode
[Add] Integrated Test and Prediction in DataLoader [Add] Config now has test-related parameters and volume masks [Add] New test script that saves results and test predictions [WIP] Prediction script on multiple gpu with integrated TIFF writing [FIXME] Reintegrate liverfiber datamodule
[Ref] Refactored DataSetConfigs [Ref] Refactored DataModule to get rid of Dataset-speficic Datamodules in favour of dataset-specific Configs [Add] Now predict_step and test_step also returns the corresponding test_key for the predicted patch [Fix] Adapted PredictionDataset to work with multiple images [Fix] Adapted training script to use a dataset agnostic datamodule instead of betaseg [Add] Updated Readme with information on how to add new datasets
[Fix] Prediction working with multiple keys and ranks, fixed perf. degradation [Fix] Test OOM issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to merge both the pseudo-epoch branch and the faster_prediction branches into main.
It adds the following main functionalities:
accumulate_grad_batchesto accumulate more gradient steps (e.g., set it to 4).Detailed Changelog:
Please refer to commit messages
More Info:
Refer to Notion for more information.