Bugfix for Peach/Daisy Turnip given to the CPU instead of the Player#750
Merged
asimon-1 merged 1 commit intojugeeya:mainfrom Nov 2, 2025
Merged
Bugfix for Peach/Daisy Turnip given to the CPU instead of the Player#750asimon-1 merged 1 commit intojugeeya:mainfrom
asimon-1 merged 1 commit intojugeeya:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating the article on the player, I'm having the fighter drop the item then am giving it to the player. This ensures that whoever generates it, the player ends up with the item in the end.
Still not 100% sure why it broke but I think it has to do with the signature change in handle_generate_article_for_target in the static mut refactor. Doesn't matter much, this method seems more reliable anyways.