Dev #34
Dev #34
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=============================================
+ Coverage 98.71% 100.00% +1.28%
- Complexity 411 513 +102
=============================================
Files 34 35 +1
Lines 1168 1312 +144
=============================================
+ Hits 1153 1312 +159
+ Misses 15 0 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| $this->expectException(ContainerException::class); | ||
| $this->expectExceptionMessage('Resolved interceptor must implement PostResolutionInterceptorInterface.'); |
There was a problem hiding this comment.
The assertion expects the thrown message to be exactly Resolved interceptor must implement PostResolutionInterceptorInterface., but ContainerException::fromInterceptor() always prefixes messages with the interceptor class (e.g. [Tests\Unit\Container\Stubs\StubInterceptor] …). This causes the new test to fail even though the code behaves correctly. Include the [$interceptorClass] prefix or assert a substring instead.
Useful? React with 👍 / 👎.
| $this->expectException(ContainerException::class); | ||
| $this->expectExceptionMessage('Resolved interceptor must implement PreResolutionInterceptorInterface.'); |
There was a problem hiding this comment.
Similar to the post-interceptor test, the expectation omits the class prefix added by ContainerException::fromInterceptor(). The actual message will be [Tests\Unit\Container\Stubs\StubPreInterceptor] Resolved interceptor must implement PreResolutionInterceptorInterface., so the assertion as written will always fail. Either assert the full prefixed message or relax the check.
Useful? React with 👍 / 👎.
| $this->expectException(ContainerException::class); | ||
| $this->expectExceptionMessage('Reflection error: Mocked reflection failure.'); | ||
|
|
There was a problem hiding this comment.
ContainerException::fromServiceId() formats messages as Error with service '<id>': …. The new test expects only Reflection error: Mocked reflection failure. so it will fail even though the resolver correctly wraps the ReflectionException. Update the expected message to include the leading Error with service 'serviceWithReflectionFailure': portion or assert a substring instead.
Useful? React with 👍 / 👎.
…binding instructions
…ntly across service classes
No description provided.