Skip to content

fix: add Windows support for CLI path and command execution #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srjkoolen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add Windows support for CLI path and command execution #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ class ClaudeCLIExecutor {

try {
// Escape path for shell
const escapedPath = customPath.replace(/'/g, "'\\'\''");
const testCommand = `'${escapedPath}' --version`;
const escapedPath = customPath;
const testCommand = `"${escapedPath}" --version`;
if (this.debugMode) {
outputChannel.appendLine(`[CUSTOM PATH] Test command: ${testCommand}`);
}
Expand Down Expand Up @@ -279,32 +279,20 @@ class ClaudeCLIExecutor {
outputChannel.appendLine(`[EXECUTE] Using path: ${this.claudePath}`);
}

// Use base64 encoding to completely avoid shell escaping issues
const base64Prompt = Buffer.from(prompt, 'utf8').toString('base64');

// Build command that decodes base64 and pipes to claude
let command = `echo "${base64Prompt}" | base64 -d | ${this.claudePath}`;

// Add all flags
command += ' --print'; // Use explicit --print flag
command += ' --model sonnet'; // Hardcoded model
command += ' --output-format json';
command += ' --dangerously-skip-permissions'; // Skip permissions check

if (this.debugMode) {
outputChannel.appendLine(`\n[EXECUTE] Command structure: echo [base64] | base64 -d | claude [options]`);
outputChannel.appendLine(`[EXECUTE] Base64 length: ${base64Prompt.length} chars`);
outputChannel.appendLine(`[EXECUTE] Original prompt length: ${prompt.length} chars`);
}

try {
// Write prompt to temp file to avoid command length limits on Windows
const os = require('os');
const fs = require('fs');
const tempFile = require('path').join(os.tmpdir(), 'claude-commit-prompt.txt');
fs.writeFileSync(tempFile, prompt, 'utf8');
const command = `type "${tempFile}" | "${this.claudePath}" --print --model sonnet --output-format json --dangerously-skip-permissions`;
if (this.debugMode) {
outputChannel.appendLine('[EXECUTE] Starting execution...');
}

const execOptions = {
timeout: 60000, // 60 seconds timeout
shell: '/bin/bash',
shell: true,
maxBuffer: 1024 * 1024 * 10, // 10MB buffer for large outputs
env: {
...process.env,
Expand Down