Add Datagrabber and cofound adaptation for cat processed HCP-Aging#2
Add Datagrabber and cofound adaptation for cat processed HCP-Aging#2jkroell wants to merge 15 commits intojuaml:mainfrom
Conversation
LeSasse
left a comment
LeSasse
left a comment
There was a problem hiding this comment.
i think maybe put it into this existing file https://github.com/juaml/juni-farm/blob/main/juni_farm/datagrabber/hcp_aging.py
then everything for hcp aging is in there and no need to then copy the existing hcp aging datagrabber.
and lastly you can then make the multiple aging datagrabber similar to https://github.com/juaml/juni-farm/blob/main/juni_farm/datagrabber/hcp_ya_confounds_cat.py#L284
dont forget to update the description and add yourself as an author
| @@ -0,0 +1,409 @@ | |||
| """Provide a datagrabber for CAT-processed confounds in the HCP dataset.""" | |||
There was a problem hiding this comment.
Can you update the description?
There was a problem hiding this comment.
Are you still waiting for an update or shall is it resolved?
There was a problem hiding this comment.
still needs an update i think @jkroell i think this file needs to be removed
There was a problem hiding this comment.
The naming is a bit awkward with the "Aging" part, maybe make it "aging"?
There was a problem hiding this comment.
i think this file actually needs to be removed, everything is in hcp_aging.py @jkroell
| """Provide a datagrabber for the HCP Aging dataset and its confounds.""" | ||
|
|
||
| # Authors: Leonard Sasse <l.sasse@fz-juelich.de> | ||
| # Authors: Leonard Sasse <l.sasse@fz-juelich.de>, Jean-Philippe Kroell <j.kroell@fz-juelich.de> |
There was a problem hiding this comment.
This needs to be in two separate lines like so:
# Authors: Leonard Sasse <l.sasse@fz-juelich.de>
# Jean-Philippe Kroell <j.kroell@fz-juelich.de>
| Returns | ||
| ------- | ||
| dict | ||
| keys (CAT variables) and values (corresponding fMRIprep variables). |
There was a problem hiding this comment.
Cosmetic nitpick: Keys (CAT variables) and values (corresponding fMRIprep variables).
| Parameters | ||
| ---------- | ||
| datadir : str or Path, optional | ||
| The directory where the datalad dataset will be cloned. |
There was a problem hiding this comment.
(default None). should be the ending for it. Before that, it'd be good to add what happens in the default case like so:
... . By default, <it-does-magic> (default None).
There was a problem hiding this comment.
Might need to go through ruff for formatting and linting.
3 participants
No description provided.