set container port with env variables#24
Open
valentinomariotto wants to merge 8 commits intojtreminio:masterfrom
Open
set container port with env variables#24valentinomariotto wants to merge 8 commits intojtreminio:masterfrom
valentinomariotto wants to merge 8 commits intojtreminio:masterfrom
Conversation
added 8 commits
September 18, 2022 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey again!
with these changes I enabled the container port to be set with an environment variable. I need to be able to set it to 80 for production.
Anyway, I was unable to get it to work with the perl module, as you did, so I ended up just replacing the variable with sed in the run it script.
Maybe you can do it properly :)
I didn't test the apache container