-
Notifications
You must be signed in to change notification settings - Fork 109
Adding community contribution #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eyy4
wants to merge
3
commits into
jtr13:master
Choose a base branch
from
eyy4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kept getting permissioning error on rstudio so seeing if this approach will work
Adding community contribution via web
Collaborator
|
You should create your own branch instead of using the master branch to create the pull request. |
Owner
|
Can you please respond to the requested changes? This is one of only two remaining pull requests to merge and we'd like to complete the project. If you need help with the instructions please email me. |
Collaborator
|
@vg00164 why do you close this? |
Collaborator
|
I did it accidentally. I opened as soon as I realized
On Thu, Nov 14, 2019 at 7:47 PM Tian Wang ***@***.***> wrote:
@vg00164 <https://github.com/vg00164> why do you close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#126?email_source=notifications&email_token=AKNP2ZUTSOQBTMSYKQXFWTLQTXWQTA5CNFSM4JHARDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEED4CEA#issuecomment-554156304>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKNP2ZR7JQLENED474KD7XLQTXWQTANCNFSM4JHARDJQ>
.
--
Regards,
Venkat
|
Collaborator
|
She created another pull request and its good.
Completed the review.
… On Nov 15, 2019, at 6:39 AM, Venkata Reddy Gangireddy ***@***.***> wrote:
I did it accidentally. I opened as soon as I realized
On Thu, Nov 14, 2019 at 7:47 PM Tian Wang ***@***.*** ***@***.***>> wrote:
@vg00164 <https://github.com/vg00164> why do you close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#126?email_source=notifications&email_token=AKNP2ZUTSOQBTMSYKQXFWTLQTXWQTA5CNFSM4JHARDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEED4CEA#issuecomment-554156304>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNP2ZR7JQLENED474KD7XLQTXWQTANCNFSM4JHARDJQ>.
--
Regards,
Venkat
|
Owner
|
What's the status of this? Was it submitted as a separate PR? |
Collaborator
|
I request the review for the conflict, but i didnt hear from them who gave
us a git hub review on that specific friday.
On Tue, Nov 19, 2019 at 10:58 PM Joyce Robbins ***@***.***> wrote:
What's the status of this? Was it submitted as a separate PR?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#126?email_source=notifications&email_token=ANTYKZTAV6IVXJHWIJE7FYDQUSYV3A5CNFSM4JHARDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQT4CQ#issuecomment-555826698>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANTYKZXIBM4LQK4JFNGUXNLQUSYV3ANCNFSM4JHARDJQ>
.
--
*Woo Jin (Nate) Kim*
Columbia University, M.S in Data Science
Brigham Young University, B.S in Mathematics and Statistics
https://www.linkedin.com/in/natewjkim
470-601-1510 wk2340@columbia.edu
|
Owner
Author
|
Hi Professor Robbins -
I'm so sorry. I signed up for GitHub ages ago with a separate email from my
Columbia email account and this was getting shoved into a weird folder.
Would you happen to have time before class on Monday or any time
before/after class on Wednesday?
Best,
Liz
…On Tue, Nov 19, 2019 at 11:20 PM Joyce Robbins ***@***.***> wrote:
Thanks @kwj1282 <https://github.com/kwj1282>. I see now that it wasn't
submitted from a non-master branch. @eyy4 <https://github.com/eyy4>: Can
you meet with me after class tomorrow so I can show you how to fix it and
we can wrap this up?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#126?email_source=notifications&email_token=AILNGVA3ALDQCZVIHOBCXRTQUS3ILA5CNFSM4JHARDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQU4FY#issuecomment-555830807>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AILNGVG6FDJMORZTWHQ6U3TQUS3ILANCNFSM4JHARDJQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.