Skip to content

Add Code Coverage #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtenner wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Code Coverage #24

jtenner wants to merge 7 commits into from

Conversation

@jtenner
Copy link
Owner

@jtenner jtenner commented Jun 23, 2021

No description provided.

@jtenner jtenner changed the title finally Add Code Coverage Jun 23, 2021
@RedDwarfian
Increased Code Coverage to 84.1%
dfb9c16 
New Tests!
New Ignorance!
Removed an unneeded isNullable check!
@RedDwarfian
Increased Code Coverage to 97.6%
c5904aa 
Expanded Map testing to check all possible byte lengths for numbers.
@RedDwarfian
Increased code coverage to 100%
427fc03 
Not proud of this one, had to put the ignore in a really odd place.
@RedDwarfian
Reducing Code Coverage to 97.6%
1a329ef 
Reverting previous commit.
@RedDwarfian
Revert "Reducing Code Coverage to 97.6%"
16d39d6 
This reverts commit 1a329ef.
@RedDwarfian
Addendum to ensure 100% coverage
885c055 
Added dedicated object-to-object test.
Documented an error on the übermenschObject.
@RedDwarfian
Copy link
Collaborator

RedDwarfian commented Jun 26, 2021 •
edited
Loading

The instances of default: assert(false); in the part of the Deserializer that handles the mapKeyValueEntryTable would never get called under normal circumstances. This would require malformed, or manually edited buffers to be passed in, in order to be tested. After discussion with @jtenner, we have agreed that @as-cover: ignoreing these defaults is the right move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtenner @RedDwarfian