unittest fix/workaround - remove CPU options and disable control_server#22
Open
brpollock wants to merge 1 commit intojtauber:masterfrom
Open
unittest fix/workaround - remove CPU options and disable control_server#22brpollock wants to merge 1 commit intojtauber:masterfrom
brpollock wants to merge 1 commit intojtauber:masterfrom
Conversation
- CPU options were only used to pass 'pc'. Rather than adding another get_options/Options to tests,py, replacing options with a pc argument removes CPU's dependency on command-line options. - As a workaround for 'Address already in use', control_server is now enabled/disabled by memory.use_bus (which is False in unit tests).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two problems with
test.py:1, No
optionsargument passed toCPU.__init__()get_options/Options to tests,py, replacing options with a pc argument
removes CPU's dependency on command-line options.
control_serverdue toAddress already in useenabled/disabled by memory.use_bus (which is False in unit tests).
With these changes, all 59 tests pass: