Skip to content

Fixed some bugs#2

Open
KOLANICH wants to merge 1 commit intojtarrio:masterfrom
KOLANICH-libs:master
Open

Fixed some bugs#2
KOLANICH wants to merge 1 commit intojtarrio:masterfrom
KOLANICH-libs:master

Conversation

@KOLANICH
Copy link

@KOLANICH KOLANICH commented Feb 20, 2015

1 fixed bug with "Unsupported Wave Format" (#1)
2 fixed missing check on data sending

UPD:

Since this shit wasn't merged for 5 years, I just delete my repo. Here is the backup of a patch file

https://github.com/jtarrio/SoftwareModem/pull/2.patch

From a5ef5f0d0e1b2098318076ced47de4e7ccbe0e50 Mon Sep 17 00:00:00 2001
From: KOLANICH <kolan_n@mail.ru>
Date: Sat, 21 Feb 2015 01:38:05 +0300
Subject: [PATCH] Fixed some bugs 1 fixed bug with "Unsupported Wave Format"
 (https://github.com/jtarrio/SoftwareModem/issues/1) 2 fixed missing check on
 data sending

---
 SoftwareModem/MainWindow.xaml.cs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/SoftwareModem/MainWindow.xaml.cs b/SoftwareModem/MainWindow.xaml.cs
index 6bae4c7..7a6b758 100644
--- a/SoftwareModem/MainWindow.xaml.cs
+++ b/SoftwareModem/MainWindow.xaml.cs
@@ -107,12 +107,14 @@ private WasapiCapture GetCaptureDevice()
             var device = lineInBox.SelectedItem as MMDevice;
             var capture = new NAudio.CoreAudioApi.WasapiCapture(device);
             capture.ShareMode = AudioClientShareMode.Shared;
-            capture.WaveFormat = new WaveFormat();
             return capture;
         }
 
         private void SendButton_Click(object sender, RoutedEventArgs e)
         {
+            if (modem==null) {
+                MessageBox.Show("Connection is not set up", "Error", MessageBoxButton.OK, MessageBoxImage.Error);
+            }
             var bytes = new byte[InputBox.Text.Length];
             for (int i = 0; i < InputBox.Text.Length; ++i)
             {

1 fixed bug with "Unsupported Wave Format" (#1)
2 fixed missing check on data sending
@andy5995
Copy link

@KOLANICH
Copy link
Author

@andy5995, ????

My repo is already a fork, isn't it?

@andy5995
Copy link

andy5995 commented Dec 30, 2020

@andy5995, ????

My repo is already a fork, isn't it?

Yes, @KOLANICH it's a GitHub fork, but you may want to create a "fork" that's separated from the existing main project. Then you can merge in your changes, and maintain the project in the future. You could duplicate this repository (as mentioned in the link I gave above), and rename it to 'SoftwareModem-ng' or something ('ng' is sometimes used to indicate "next generation"). Your new repo, after being duplicated/mirrored, would keep the entire commit history of this project.

@KOLANICH
Copy link
Author

I actually want to delete my repo, not to maintain an own fork. I don't use C# anymore because of M$ disrespectful attitude to users of it (i.e. telemetry in the only official SDK, since Xamarin has dropped own SDK in favour of M$ one after it was bought by M$).

@andy5995
Copy link

I actually want to delete my repo, not to maintain an own fork. I don't use C# anymore because of M$ disrespectful attitude to users of it (i.e. telemetry in the only official SDK, since Xamarin has dropped own SDK in favour of M$ one after it was bought by M$).

Oh, I get it. I've never used C# but I see where you're coming from.

@KOLANICH
Copy link
Author

C# 100.0%
I've never used C#

What are you doing in this repo then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants