feat(signer-ext): jstz-signer extended#58
Open
bohdan-trilitech wants to merge 3 commits intoryan/signer-extensionfrom
Open
feat(signer-ext): jstz-signer extended#58bohdan-trilitech wants to merge 3 commits intoryan/signer-extensionfrom
bohdan-trilitech wants to merge 3 commits intoryan/signer-extensionfrom
Conversation
Collaborator
bohdan-trilitech
commented
Apr 28, 2025
bohdan-trilitech
commented
- tests added;
- extended with CHECK_STATUS event;
- timeout added for avoiding waiting for extension's response indefinitely
- namespace export removed
Collaborator
Author
|
@zcabter i've removed "namespace" export as it created some heavy confusion for the compiler on how to treat "enums" as they're used both on compile time (as type) and runtime (as value). It produced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.