Update survey plugin to use default CSS as much as possible #3619
Conversation
…r, add examples for testing
🦋 Changeset detectedLatest commit: 75bec28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
This looks great! I left some comments with questions/suggestions.
One thing I think is missing from this PR: we should remove all of the CSS in survey.scss, other than importing survey-core.min.css. For the most part, the CSS in there doesn't do anything because the class map has been removed. But there are some rules that don't use those custom classes for selectors and therefore are still being applied. (E.g. input[type="text"] {width: auto;} is now causing the textbox to overflow in some cases - see screenshot).
Here's what I think is left to do:
- Remove everything in
survey.scssexcept@use "survey-core/survey-core.min.css"; - Remove references to custom CSS classes (now removed)
- Update docs with new SurveyJS version, new
min_widthparameter, and possibly more info/examples relating to the new features that have been added to SurveyJS - Update examples and/or demos with new features that have been added to SurveyJS
- Fix tests
- Update docs on mobile device compatibility
- Add changeset
Happy to do any of these things, if you want - just let me know if I should push to this branch or create a new PR.
|
If you could work on the fixes on this branch that would be great! |
… selecting nav complete button
…bile compatibility
…ions, use displayMode: default to show switch from rating buttons to dropdown on mobile
|
This looks fantastic. Thank you! |
No description provided.