Open
Conversation
jsma
force-pushed
the
support-multiple-references-to-footnotes
branch
from
e1814e5 to
001bdab
Compare
jsma
force-pushed
the
support-multiple-references-to-footnotes
branch
from
e1bf09c to
2029673
Compare
jsma
force-pushed
the
support-multiple-references-to-footnotes
branch
3 times, most recently
from
75ec95f to
6990138
Compare
jsma
force-pushed
the
support-multiple-references-to-footnotes
branch
from
6990138 to
5a94412
Compare
Previously every link in the rich text for the same footnote had the same `id` attribute, which breaks the "Back to content" link (or just always returns the user to the first reference). This now generates a unique `id` for each footnote reference and updates the `footnotes.html` template to generate unique links back to each reference in the content.
jsma
force-pushed
the
support-multiple-references-to-footnotes
branch
from
5a94412 to
1bedf7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP