Create Transformers Pro (Stern 2011) v.2.2.vbs.original

[Growlfy]

Add new vbs table

[francisdb]

@jsm174 can you approve the workflow?

[jsm174]

Hello. @Growlfy - It looks like you created two PRs, one for each file. You'll need to fix this one or that one -- to include all the files -- so we can accurately review it.

[Growlfy]

@jsm174 OK, this is my first pull request, so I'm a bit confused. I just modified it. Is it correct?

[jsm174]

yes, but you should also include the patch file, so it's easier for us to review. There's a script in the root that will generate that part.

Also, fwiw, we try to address just the known wine quirks, and not try to patch the logic for a table because of a bug.

[Growlfy]

The patch file is generate by CI isn't it?

Note :
You do not need to submit [table.vbs.patch] in your PR as the CI will generate these automatically.

[francisdb]

True, but it's hard to evaluate a patch file without the diff.

[jsm174]

ahh. I did not see that entry in the readme. Guess I did a bad job on reviewing the PR that added that message. 😥

Anyway, if you could add it, we would appreciate it. It really helps out deciding if the patch makes it into the repo.

[Growlfy]

patch file is online :)

[Growlfy]

Just in case :
There's a problem in the Apron_Hit subroutine, which is called too early. I think ActiveBall.id is not properly defined when the function is called.

Here’s the debug : code line 3314

'Old Apron_Hit sub :
'Sub Apron_Hit (idx)
' If Abs(cor.ballvelx(ActiveBall.id) < 4) And cor.ballvely(ActiveBall.id) > 7 Then
' RandomSoundBottomArchBallGuideHardHit()
' Else
' RandomSoundBottomArchBallGuide
' End If
'End Sub
Sub Apron_Hit(idx)
If Not IsEmpty(ActiveBall) And Not ActiveBall Is Nothing Then
On Error Resume Next
Dim ballId
ballId = ActiveBall.id
If Err.Number = 0 Then ' Check access to ActiveBall.id
If Abs(cor.ballvelx(ballId) < 4) And cor.ballvely(ballId) > 7 Then
RandomSoundBottomArchBallGuideHardHit()
Else
RandomSoundBottomArchBallGuide
End If
End If
On Error Goto 0
End If
End Sub

[Growlfy]

Hi @jsm174,

Thanks for your feedback and for pointing out the missing patch file. I've added it as requested.

Regarding the Apron_Hit subroutine, I understand your point about focusing on known wine quirks. However, I believe this fix is necessary for the pinball’s proper functioning, as ActiveBall.id was causing issues.

Let me know if you think there's a better way to address it.

Best regards

[francisdb]

Not possible to fix this without catching errors?

[Growlfy]

Oh, indeed, I forgot to remove the lines of code that temporarily ignore errors — that was my test version.

Sub Apron_Hit(idx)
If Not IsEmpty(ActiveBall) And Not ActiveBall Is Nothing Then
Dim ballId
ballId = ActiveBall.id
If Err.Number = 0 Then ' Vérifier si l'accès à ActiveBall.id a réussi
If Abs(cor.ballvelx(ballId) < 4) And cor.ballvely(ballId) > 7 Then
RandomSoundBottomArchBallGuideHardHit()
Else
RandomSoundBottomArchBallGuide
End If
End If
End If
End Sub

[francisdb]

Can you add a link to the table download in the PR description?

[Growlfy]

@francisdb The original table is the 2.2 version of this table : https://vpuniverse.com/files/file/15565-transformers-pro-stern-2011/

[francisdb]

I guess we better create a patch for the 2.3.1 version if still required?

How do I reproduce the issue? The table runs fine on first sight.

[Growlfy]

@francisdb I’ve just tested the new version (2.3.1), and everything works fine without the patch. I recently upgraded to a more powerful computer, so it seems the patch is no longer necessary. I wonder if my old machine was simply too slow to create the ballId variable in time.

Thanks for taking my request into account. I think i can close it now :)

[Growlfy]

V2.3.1 seems to work properly without the patch.