Skip to content

PR from Anatolij #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vodolaz095 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

PR from Anatolij #10

vodolaz095 wants to merge 4 commits into from

Conversation

@vodolaz095
Copy link

@vodolaz095 vodolaz095 commented Oct 16, 2021 •
edited
Loading

  1. Implement gomodules properly
  2. upgrade comments to make golint happier
  3. typos fixed
  4. Processor changed to Possessor, like they explain in man documentation
  5. Backported ARM uniptr's from Add syscall IDs for ARM #8
  6. Generate better documentation for https://pkg.go.dev/github.com/jsipprell/keyctl
  7. UPD travis config to include newer golang versions
  8. GNU Makefile to make things simpler

@vodolaz095
1. upgrade comments to make golint happier
c0d87b1 
2. typos fixed
3. Processor changed to Possessor, like they explain in man documentation
4. Backported ARM uniptr's from jsipprell#8
5. Generate better documentation for https://pkg.go.dev/github.com/jsipprell/keyctl
6. UPD travis config to include newer golang versions
@vodolaz095 vodolaz095 mentioned this pull request Oct 16, 2021
Open
jsipprell
jsipprell requested changes Oct 19, 2021
View reviewed changes
Copy link
Owner

@jsipprell jsipprell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (partially) breaks backwards-compatibility by introducing exported symbol changes. The in-line documentation changes also do not reflect some of the symbol changes.

If we're going to do a change like this it should be separated into backwards and non-backwards compatible PRs.

@vodolaz095
Copy link
Author

vodolaz095 commented Oct 20, 2021

yes, and i have pushed tag to depict version changed

@jsipprell
Copy link
Owner

jsipprell commented Oct 20, 2021

It's my understanding that mere tagging isn't sufficient. The import path actually needs to change to accomodate a non-backwards compatible v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsipprell jsipprell jsipprell requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vodolaz095 @jsipprell