Skip to content

Conversation

@yy214123
Copy link
Contributor

@yy214123 yy214123 commented Apr 8, 2025

Correct ROW and COL labels in comments to match standard definitions—column as vertical and row as horizontal. This change improves code clarity and prevents potential confusion when interpreting line direction logic.

Copy link
Collaborator

@visitorckw visitorckw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and squash the commits into one.
We don't want a PR to contain commits that fix mistakes from earlier commits in the same PR.

Correct ROW and COL labels in comments to match standard
definitions—column as vertical and row as horizontal. This change
improves code clarity and prevents potential confusion when
interpreting line direction logic.
@yy214123 yy214123 force-pushed the fix-comment-errors branch from 8af6a76 to 35814b1 Compare April 8, 2025 04:51
Copy link
Collaborator

@visitorckw visitorckw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jserv jserv merged commit 7f4f911 into jserv:main Apr 8, 2025
2 checks passed
@jserv
Copy link
Owner

jserv commented Apr 8, 2025

Thank @yy214123 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants