Conversation
This replaces field-level #[serde(default = "fn")] with struct-level '#[serde(default)]' across CacheConfig, ResilienceConfig, Config, and PreserveConfig, using Default impl as single source of truth. It deduplicates handle_show_preserved() from 6 repetitive if-blocks into a data-driven loop while preserving per-category header colors and per-segment display formatting (truncation/newline-escape for CodeBlock only, .yellow() + "(markers stripped)" for NoTranslate, .blue() for EnglishTerm, .dimmed() for the rest).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 65.16% 68.24% +3.08%
==========================================
Files 11 11
Lines 775 762 -13
==========================================
+ Hits 505 520 +15
+ Misses 270 242 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces field-level
#[serde(default = "fn")]with struct-level#[serde(default)]across CacheConfig, ResilienceConfig, Config, and PreserveConfig, using Default impl as single source of truth.It deduplicates handle_show_preserved() from 6 repetitive if-blocks into a data-driven loop while preserving per-category header colors and per-segment display formatting (truncation/newline-escape for CodeBlock only, .yellow() + "(markers stripped)" for NoTranslate, .blue() for EnglishTerm, .dimmed() for the rest).