Conversation
The resilience config (circuit breaker thresholds, HTTP timeouts, retry counts, backoff delays) was defined in ResilienceConfig but never wired to the translator -- all three OnceLock singletons used hardcoded defaults. Similarly, fallback_to_passthrough existed in config but was never checked; translation errors unconditionally returned the original text. Fix both by: - Adding init_resilience() to seed OnceLock singletons (circuit breaker, rate limiter, HTTP client) with user config before the first request - Threading &ResilienceConfig through translate_with_chunking, translate_chunks, and google_translate_with_retry_config - Extracting build_http_client() as single source of truth for the reqwest::Client builder (eliminates duplicated chain) - Checking config.resilience.fallback_to_passthrough in main.rs error handler: true (default) returns original text, false exits with status 1 - Guaranteeing at least one translation attempt even if max_retries is 0 (prevents u32 wrapping and zero-attempt failure)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 65.37% 65.16% -0.22%
==========================================
Files 11 11
Lines 774 775 +1
==========================================
- Hits 506 505 -1
- Misses 268 270 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resilience config (circuit breaker thresholds, HTTP timeouts, retry counts, backoff delays) was defined in ResilienceConfig but never wired to the translator -- all three OnceLock singletons used hardcoded defaults. Similarly, fallback_to_passthrough existed in config but was never checked; translation errors unconditionally returned the original text.
Fix both by: