Improve README.md for installation and issue#100
Improve README.md for installation and issue#100marconi1964 wants to merge 2 commits intojserv:masterfrom
Conversation
| $ sudo apt-get install gcc-arm-linux-gnueabihf | ||
|
|
||
| # set QEMU_LD_PREFIX path | ||
| $ export QEMU_LD_PREFIX=/usr/arm-linux-gnueabihf |
There was a problem hiding this comment.
Don't rely on manual environment setting. Instead, improve the build system to validate Arm toolchain installation. If the GNU toolchain was downloaded and extracted from Arm website, the environment variable must point to different directories.
There was a problem hiding this comment.
Not considering manual environment setting, and cannot set shell environment variable from make (Linux shell limitation, I understand), can only think of make qemu ./amacc tests/hello.c such kind of implementation. Not sure if that is the right approach?
Would consider manual environment setting if build system can search the ARM link library and prompt path info for user to set it manually?
There was a problem hiding this comment.
Someone (at least for me) might install a bunch of GNU toolchains and/or QEMU packages, and directory /usr/arm-linux-gnueabihf would not be always correct per installation. At present, mk/arm.mk manages to check the corresponding files once $PATH is set properly. You can extend the existing checks.
There was a problem hiding this comment.
Right, and mk/arm.mk also checks $QEMU_LD_PREFIX as well. It works and gets the LD path on my system (but not passing to qemu), can look into that in more details. With this PR, trying to fix is different. It is to fix the $QEMU_LD_PREFIX path issue on shell when executing qemu-arm.
There was a problem hiding this comment.
Again, let the build system detect the runtime libraries, and you can send pull requests to consolidate it if you found its shortcomings.
|
|
||
| Check the messages generated by `make help` to learn more. | ||
|
|
||
|
|
There was a problem hiding this comment.
Don't change this line. Minimize the necessary changes.
2 participants
Improve README.md for arm tool chain installation and potential issue on QEMU_LD_PREFIX path