Implement “internally create a new object implementing the interface”#239
Merged
domenic merged 1 commit intojsdom:masterfrom Mar 20, 2021
Merged
Conversation
2 tasks
ExE-Boss
force-pushed
the
feat/internally-create-new-object
branch
from
eb897a2 to
970cf26
Compare
domenic
approved these changes
Mar 20, 2021
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
I'm sad about the extra size for such an edge-case feature, but it seems unavoidable, and I appreciate the work you did to make it shorter by using different steps than the spec (with equivalent logic).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #213 because of #213 (comment):
Blocks:
[LegacyFactoryFunction]#213