Skip to content

test: Add NoUselessIfElse.webidl#233

Closed
ExE-Boss wants to merge 1 commit intojsdom:mainfrom
ExE-Boss:test/cases/no-useless-if-else
Closed

test: Add NoUselessIfElse.webidl#233
ExE-Boss wants to merge 1 commit intojsdom:mainfrom
ExE-Boss:test/cases/no-useless-if-else

Conversation

@ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jan 3, 2021

Extracted from #231

@domenic
Copy link
Member

domenic commented Mar 7, 2021

This doesn't seem to address @TimothyGu's comment in #231 of

I'd also prefer a more surgical test suite. The snapshot generated from this file is really huge and not reviewable.

@domenic
Copy link
Member

domenic commented Sep 29, 2025

Fixed in a different way as part of #276. (I apologize for holding this to such a high standard back in 2021; these days I'm more lenient.)

@domenic domenic closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants