Precompute concatenated strings where possible#221
Open
ExE-Boss wants to merge 1 commit intojsdom:mainfrom
Open
Precompute concatenated strings where possible#221ExE-Boss wants to merge 1 commit intojsdom:mainfrom
ExE-Boss wants to merge 1 commit intojsdom:mainfrom
Conversation
ExE-Boss
force-pushed
the
refactor/precompute-concatenated-strings
branch
from
5fc3c6b to
b8918b0
Compare
TimothyGu
reviewed
May 10, 2020
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
I was hoping for something a bit more ambitious, where string concatenations are done by a library function that handles all of the " to template literal conversion and de-stringification. Perhaps it could even be a class that can be passed around through the various context parameters we have in types.js. Manually changing things, in some cases making things less readable in the webidl2js source, wasn't what I had in mind.
| if (arguments.length < 1) { | ||
| throw new TypeError("Failed to execute 'forEach' on '${this.name}': 1 argument required, " + | ||
| "but only 0 present."); | ||
| throw new TypeError("Failed to execute 'forEach' on '${this.name}': 1 argument required, but only 0 present."); |
Member
There was a problem hiding this comment.
I'd rather keep this the way it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217