Implement support for [LegacyWindowAlias] and [NoInterfaceObject]#191
Merged
TimothyGu merged 4 commits intojsdom:masterfrom Apr 4, 2020
Merged
Implement support for [LegacyWindowAlias] and [NoInterfaceObject]#191TimothyGu merged 4 commits intojsdom:masterfrom
[LegacyWindowAlias] and [NoInterfaceObject]#191TimothyGu merged 4 commits intojsdom:masterfrom
Conversation
ExE-Boss
changed the title
[LegacyWindowAlias][LegacyWindowAlias] and [NoInterfaceObject]
ExE-Boss
changed the title
[LegacyWindowAlias] and [NoInterfaceObject][LegacyWindowAlias] and [NoInterfaceObject]
TimothyGu
reviewed
Apr 3, 2020
Member
TimothyGu
left a comment
TimothyGu
left a comment
There was a problem hiding this comment.
It seems to make sense to implement [Exposed] in this PR too, as it seems odd that the globalName is only used for [LegacyWindowAlias]. But up to you.
Co-Authored-By: Timothy Gu <timothygu99@gmail.com>
Contributor
Author
|
|
4 tasks
TimothyGu
approved these changes
Apr 4, 2020
ExE-Boss
commented
Apr 4, 2020
|
|
||
| this.str += ` | ||
| exports.install = function install(globalObject) { | ||
| exports.install = (globalObject, globalName) => { |
Contributor
Author
There was a problem hiding this comment.
After re‑reading the spec for [Global] and [Exposed], I realised that this needs globalNames instead of globalName.
I’m fixing that in #190.
domenic
added a commit
that referenced
this pull request
Apr 19, 2020
This reverts the breaking changes introduced in #191, since it was accidentally released as a minor version in v15.2.0, while keeping the functionality.
domenic
added a commit
that referenced
this pull request
Apr 20, 2020
This reverts the breaking changes introduced in #191, since it was accidentally released as a minor version in v15.2.0, while keeping the functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
review?(@TimothyGu)