feat(Global): Add support for named getters#167
Closed
ExE-Boss wants to merge 4 commits intojsdom:masterfrom
Closed
feat(Global): Add support for named getters#167ExE-Boss wants to merge 4 commits intojsdom:masterfrom
ExE-Boss wants to merge 4 commits intojsdom:masterfrom
Conversation
ExE-Boss
force-pushed
the
feat/global/named-getter
branch
from
63516e6 to
ff61f8d
Compare
7 tasks
ExE-Boss
force-pushed
the
feat/global/named-getter
branch
from
244d283 to
30091e8
Compare
This was referenced Feb 15, 2020
Member
|
Seeing as this PR isn’t ready yet, I’ll close this as well as other global-related PRs. I’d like to see a single comprehensive PR for the global object rather than pieces of it that independently don’t compose a usable feature. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
within Node (nodejs/node#30985)This implements the named properties object.
Needed for jsdom/jsdom#2835
Supersedes and closes #25
Supersedes and closes #96