Add conversion for SharedArrayBuffer#50
Merged
domenic merged 5 commits intojsdom:masterfrom Sep 8, 2025
Merged
Conversation
Member
Removing it seems better to me! |
Contributor
Author
|
All right, I'll do that. I'll keep the |
domenic
approved these changes
Sep 8, 2025
Member
|
Let me know if you'd like me to cut a new release now, or wait for the [AllowResizable] support first. |
Contributor
Author
|
Opened #51. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of whatwg/webidl#1311, WebIDL has its own
SharedArrayBuffertype. I added aconversions.SharedArrayBufferfunction to properly recognize this.I also noticed that this conversion was incorrectly throwing an error, so I fixed that:
Questions:
[AllowShared] ArrayBuffer. However, that's no longer supported: you can only apply[AllowShared]on a buffer view type. For now, I've kept theallowSharedoption around inconversions.ArrayBuffer, but perhaps we should remove it instead?