-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ci): pin playwright@1.58.2 and vite@7.3.1 to fix ubuntu CI failures #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| id: fix-ci-playwright-vite-overrides-2026-03-22 | ||
| tool: claude-code | ||
| mode: normal | ||
| task: "Fix failing CI on main branch: ubuntu build failing due to two playwright versions (1.58.1 + 1.58.2) coexisting and a phantom vite@6.4.1 variant causing vitest module resolution failure." | ||
| constraints: | ||
| - "follow PR template exactly" | ||
| - "no secrets" | ||
| - "pin playwright and vite to single versions via pnpm.overrides" | ||
| outputs_expected: | ||
| - "package.json (overrides + bump playwright/playwright-test to 1.58.2)" | ||
| - "pnpm-lock.yaml (regenerated without vite@6 and playwright@1.58.1 variants)" | ||
| - "ai/prompts/2026-03-22-fix-ci-playwright-vite-overrides.yaml" | ||
| - "ai/sessions/2026-03-22-fix-ci-playwright-vite-overrides.json" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "tool": "claude-code", | ||
| "started_at": "2026-03-22T15:51:00Z", | ||
| "ended_at": "2026-03-22T16:10:00Z", | ||
| "files_touched": ["package.json", "pnpm-lock.yaml"], | ||
| "tests_run": ["pnpm install (lockfile regeneration)"], | ||
| "human_verification": "Verified vite@6 refs dropped to 0 and playwright@1.58.1 refs dropped to 0 in regenerated lockfile. pnpm install completed successfully with +8/-15 packages.", | ||
| "notes": "Root cause: @vitest/mocker@4.0.18 accepts vite ^6||^7 as peer dep. vite-plugin-istanbul@6.0.2 has peer dep vite >=4 <=6 (out of range for project vite@7). pnpm was resolving a phantom vite@6.4.1 branch, which cascaded into a second @vitest/browser-playwright variant using playwright@1.58.2+vite@6.4.1. Separately, @argos-ci/playwright@6.4.2 (transitive via @argos-ci/storybook) introduced playwright@1.58.2 alongside the root playwright@1.58.1, causing the two-versions Playwright singleton conflict. Fix: add pnpm.overrides for playwright=1.58.2, playwright-core=1.58.2, vite=7.3.1 to collapse all variants to a single version each." | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,15 +105,15 @@ | |
| "@changesets/cli": "^2.27.1", | ||
| "@modelcontextprotocol/inspector": "^0.19.0", | ||
| "@openai/apps-sdk-ui": "0.2.1", | ||
| "@playwright/test": "^1.58.1", | ||
| "@playwright/test": "^1.58.2", | ||
| "@vitest/browser-playwright": "^4.0.18", | ||
| "@vitest/coverage-v8": "^4.0.18", | ||
| "agent-browser": "0.17.0", | ||
| "ajv": "^8.18.0", | ||
| "concurrently": "^9.2.1", | ||
| "fast-check": "^4.5.3", | ||
| "hono": "^4.12.7", | ||
| "playwright": "^1.58.1", | ||
| "playwright": "^1.58.2", | ||
| "sharp": "^0.34.5", | ||
| "tsx": "^4.21.0", | ||
| "typescript": "^5.9.3", | ||
|
|
@@ -156,7 +156,10 @@ | |
| "ajv@>=7.0.0 <8.18.0": ">=8.18.0", | ||
| "minimatch@<3.1.4": ">=3.1.4", | ||
| "minimatch@>=9.0.0 <9.0.7": ">=9.0.7", | ||
| "minimatch@>=10.0.0 <10.2.3": ">=10.2.3" | ||
| "minimatch@>=10.0.0 <10.2.3": ">=10.2.3", | ||
| "playwright": "1.58.2", | ||
| "playwright-core": "1.58.2", | ||
| "vite": "7.3.1" | ||
|
Comment on lines
+160
to
+162
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Useful? React with 👍 / 👎. |
||
| }, | ||
| "publicHoistPattern": [ | ||
| "@storybook/*", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we refresh the lockfile after Playwright publishes any newer 1.x release,
@playwright/testcan advance past1.58.2while the new overrides keepplaywright/playwright-corefixed at1.58.2. The lockfile shows@playwright/testdepends on the matchingplaywrightversion (pnpm-lock.yaml:9555-9557), so that future install will recreate the cross-version skew this change is trying to eliminate and can breakpnpm exec playwright ...in CI/local test runs. Pinning@playwright/testto the same exact version avoids the mismatch.Useful? React with 👍 / 👎.