Skip to content

Add AASHyperbolic class#26

Open
laheller wants to merge 1 commit intojsauve:masterfrom
laheller:master
Open

Add AASHyperbolic class#26
laheller wants to merge 1 commit intojsauve:masterfrom
laheller:master

Conversation

@laheller
Copy link
Copy Markdown
Collaborator

@laheller laheller commented Dec 7, 2025

Hi

@jsauve @elendil-software

PJ Naughter, author of AA+ added new classes like CAAHyperbolic to his library and I ported it to AASharp. I also updated the examples to show, how to get information about a comet like for example the 3I/ATLAS with a hyperbolic orbit (i. e. with an eccentricity > 1). Looks like it works correctly, when I compare the results with the information about 3I/ATLAS as showed in Stellarium. However one thing I am not sure about, the new version number of AASharp in such a case. In the commit I changed it to 2.13.0.

BR,

Ladislav

New version

Add AASHyperbolic class
@elendil-software
Copy link
Copy Markdown
Collaborator

@laheller
Looks like there is something wrong with the unit tests. This is not related to your modifications. For some reason the test don't pas the build pipeline anymore.

@jsauve
Copy link
Copy Markdown
Owner

jsauve commented Jan 4, 2026

Sorry for the delay in response.

The test failure output is here:
https://github.com/jsauve/AASharp/actions/runs/20009250567/job/59143436456#step:7:96

It looks like it first appeared on Dec 7th? Any ideas on what caused the unit test to start failing?

@laheller
Copy link
Copy Markdown
Collaborator Author

laheller commented Jan 5, 2026

@jsauve @elendil-software
Happy new year!

Yes, it's weird that those unit tests are failing, because I did not even touch that part (the AASCoordinateTransformation class).

Anyway, since I noticed, that PJ Naughter changed the CAAHyperbolic class and released a new version of AA+ since this PR, I recommend ti cancel or at least rework this PR and go with the latest CAAHyperbolic implementation from AA+.
What do you think?

Also, what about the version numbering of AASharp in case when we add for example a new class?

BR,

Ladislav

@elendil-software
Copy link
Copy Markdown
Collaborator

Yes, it's weird that those unit tests are failing because I did not even touch that part (the AASCoordinateTransformation class).

I remember that I already have this behaviour when running the test with .NET Framework and .NET Core. Maybe we have the same thing with recent .NET version

Also, what about the version numbering of AASharp in case when we add for example a new class?

In the previous version I tried to use the same version than AA+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants