Conversation
New version Add AASHyperbolic class
|
@laheller |
|
Sorry for the delay in response. The test failure output is here: It looks like it first appeared on Dec 7th? Any ideas on what caused the unit test to start failing? |
|
@jsauve @elendil-software Yes, it's weird that those unit tests are failing, because I did not even touch that part (the AASCoordinateTransformation class). Anyway, since I noticed, that PJ Naughter changed the CAAHyperbolic class and released a new version of AA+ since this PR, I recommend ti cancel or at least rework this PR and go with the latest CAAHyperbolic implementation from AA+. Also, what about the version numbering of AASharp in case when we add for example a new class? BR, Ladislav |
I remember that I already have this behaviour when running the test with .NET Framework and .NET Core. Maybe we have the same thing with recent .NET version
In the previous version I tried to use the same version than AA+ |
Hi
@jsauve @elendil-software
PJ Naughter, author of AA+ added new classes likeCAAHyperbolicto his library and I ported it to AASharp. I also updated the examples to show, how to get information about a comet like for example the 3I/ATLAS with a hyperbolic orbit (i. e. with an eccentricity > 1). Looks like it works correctly, when I compare the results with the information about 3I/ATLAS as showed inStellarium. However one thing I am not sure about, the new version number of AASharp in such a case. In the commit I changed it to2.13.0.BR,
Ladislav