Skip to content

Add support for React 19 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soasada wants to merge 2 commits into from
Closed

Add support for React 19 #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c55ca4c
fix: update to react 19
soasada Oct 31, 2025
723403e
fix: build error
soasada Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Copy link
Owner

@jsardev jsardev Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: package-lock should not be in here as we use yarn
suggestion: directories like .idea should be in everyone's personal global configs, not in repositories as it's a personal preference, not something related to the codebase

Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ dist/
node_modules/
coverage/
*.log
*.d.ts
*.d.ts
.idea/
package-lock.json
4 changes: 3 additions & 1 deletion lib/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ class Reaptcha extends Component<Props, State> {
key={this.state.instanceKey}
id={this.props.id}
className={this.props.className}
ref={e => (this.container = e)}
ref={e => {
Copy link
Owner

@jsardev jsardev Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: please leave the formatting as it was 🙏

this.container = e;
}}
/>
);

Expand Down
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"build": "rimraf dist && microbundle --jsx React.createElement"
},
"peerDependencies": {
"react": "^16 || ^17 || ^18"
"react": "^16 || ^17 || ^18 || ^19"
},
"devDependencies": {
"microbundle": "^0.14.2",
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"@types/enzyme": "^3.10.11",
"@types/jsdom-global": "^3.0.2",
"@types/node": "^17.0.21",
"@types/react": "^18.0.12",
"@types/react-dom": "^18.0.5",
"@types/react": "^19.2.2",
"@types/react-dom": "^19.2.2",
"@types/sinon": "^10.0.11",
"@typescript-eslint/eslint-plugin": "^5.13.0",
"@typescript-eslint/parser": "^5.13.0",
Expand All @@ -41,7 +41,7 @@
"sinon": "^9.0.0",
"ts-node": "^10.7.0",
"turbo": "^1.1.4",
"typescript": "~4.5.0"
"typescript": "~5.6.0"
},
"husky": {
"hooks": {
Expand Down
Loading