Install this project exports in share#790
Merged
nim65s merged 1 commit intojrl-umi3218:masterfrom Nov 7, 2025
Merged
Conversation
Collaborator
Author
|
I don't know any better way to test this than merge it, release, push that release to ROS, and wait for build.ros2.org to tell me what is wrong. So I'll go ahead and do this. For the discussions about the proper fix, this can be offline. |
This was referenced Nov 10, 2025
nim65s
added a commit
to nim65s/dockgen
that referenced
this pull request
Nov 19, 2025
nim65s
added a commit
to nim65s/dockgen
that referenced
this pull request
Nov 19, 2025
tests: update after jrl-umi3218/jrl-cmakemodules#790
Contributor
|
This is a success on humble at least. the binary are at the proper version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
#786 was not enough to teach ROS this package is arch independent, because the buildfarm still use
-DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu: https://build.ros2.org/job/Rbin_uN64__jrl_cmakemodules__ubuntu_noble_amd64__binary/3/consoleAnd we install CMake exports in that LIBDIR:
jrl-cmakemodules/package-config.cmake
Line 31 in 97bc4fe
I think a proper fix on our side would be to expose a boolean option for arch independent packages, and install in
<prefix>/(lib/<arch>|lib*|share)/cmake/<name>*/with either CMAKE_INSTALL_LIBDIR or CMAKE_INSTALL_DATAROOTDIR depending on that option.And while here we could go instead to
<prefix>/<name>*/(lib/<arch>|lib*|share)/cmake/<name>*/which should work both on Unix and Windows. (I don't know why our current setting seems to work on windows, but the doc says it does not)ref. https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure
@ahoarau @jorisv : what would you think of something like
${PROJECT_NAME}/{CMAKE_INSTALL_LIB_OR_DATAROOT_DIR}/cmake/${PROJECT_NAME}for the v2 ?But for now, a dirty workaround is just to force CMAKE_INSTALL_LIBDIR to CMAKE_INSTALL_DATAROOTDIR in the installation of this package.
Also cc @MaximilienNaveau for the ROS issues.