Conversation
User request: "the release is already failing let's make sure we're on a clean branch so we get any release test fixes into a pr" Issue: Release workflow failed because Go binaries tried to build without generated protobuf code. Errors showed missing packages: - github.com/jrepp/prism-data-layer/pkg/plugin/gen/prism/launcher - github.com/jrepp/prism-data-layer/pkg/plugin/gen/prism Root cause: Release workflow lacked protobuf generation step that exists in CI workflow. All Go services and Rust proxy depend on generated proto code in pkg/plugin/gen/. Fix: 1. Add generate-proto job at beginning of workflow - Installs protoc, protoc-gen-go, and buf - Runs `make proto-go` to generate code - Uploads generated code as artifact 2. Make build-binaries and build-proxy depend on generate-proto 3. Add download-artifact step in both build jobs to retrieve generated proto code This mirrors the CI workflow pattern where proto generation happens once and artifacts are shared across all build jobs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release pipeline by introducing a dedicated protobuf code generation job that runs before build jobs, ensuring generated code is available for all platform builds.
Key Changes:
- Added a new
generate-protojob that creates protobuf code once and uploads it as an artifact - Modified
build-binariesandbuild-rust-proxyjobs to depend on and download the generated protobuf artifact - Centralized protobuf generation to avoid redundant generation across multiple build matrix jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Setup protoc | ||
| uses: arduino/setup-protoc@v3 | ||
| with: |
There was a problem hiding this comment.
[nitpick] The protoc version '25.x' should be documented or aligned with project requirements. Consider adding a comment explaining the version choice or verifying this matches the version used in other workflows.
| with: | |
| with: | |
| # Using protoc version 25.x to match project requirements and ensure compatibility with generated code. | |
| # This version is aligned with other workflows and documented in the project's build instructions. |
|
This PR has merge conflicts with the base branch. Please resolve them. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
|
This PR has been inactive for 14 days. Please update it or close it if it's no longer needed. |
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
User request: "look at all local branches for unmerged commits, create PRs if they are found by first merging origin/main and submitting the commit data"
This branch contains 2 unmerged commit(s). Conflicts resolved automatically with aggressive strategy.
Co-Authored-By: Claude noreply@anthropic.com