fix: use UTC timezone for timestamp conversion#48
Merged
Conversation
The previous code used `astimezone(tz=None)` which converts to local timezone, but then formatted with 'Z' suffix which implies UTC. This caused timestamps to be offset by the local timezone. Example with CST (UTC-6): - Git timestamp: 2025-10-16T23:09:56-07:00 - Bug output: 2025-10-17T01:09:56Z (local time with Z suffix) - Fixed output: 2025-10-17T06:09:56Z (actual UTC) Changed `astimezone(tz=None)` to `astimezone(timezone.utc)` for both created and updated timestamp conversions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix timezone conversion bug in
timestamps.pythat caused timestamps to be offset by the local timezone.Root cause: The code used
astimezone(tz=None)which converts to local timezone, but then formatted with 'Z' suffix which implies UTC.Example with CST (UTC-6) local timezone:
2025-10-16T23:09:56-07:00(PDT)2025-10-17T01:09:56Z(local time incorrectly marked as UTC)2025-10-17T06:09:56Z(actual UTC)Changes
Changed
astimezone(tz=None)toastimezone(timezone.utc)for both created and updated timestamp conversions inget_git_dates().Test plan