Preserve the cursor position when entering and exiting markdown-edit-code-block#914
Merged
syohex merged 1 commit intojrblevin:masterfrom Jul 18, 2025
Merged
Conversation
…-code-block` By saving and restoring the relative cursor position when entering and exiting edit-indirect mode, users can continue editing from the same location after making changes to the code block.
knu
force-pushed
the
feat/edit-code-block-preserve-point
branch
from
f596b7d to
74a695d
Compare
knu
commented
Jul 18, 2025
| (setq markdown--edit-indirect-committed-position nil)) | ||
|
|
||
| (with-eval-after-load 'edit-indirect | ||
| (advice-add #'edit-indirect-commit :after #'markdown--edit-indirect-move-to-committed-position)) |
Contributor
Author
There was a problem hiding this comment.
I had to advise these functions because existing hooks have limitations:
edit-indirect-after-commit-functionsare run from the inside of save-excursion.edit-indirect-before-commit-functionsandedit-indirect-before-commit-hookare run in the parent buffer and have no access to the edit-indirect buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By saving and restoring the relative cursor position when entering and exiting edit-indirect mode, users can continue editing from the same location after making changes to the code block.
Description
Related Issue
Type of Change
Checklist
make test).