Make markdown-mouse-follow-link work when nil#610
Open
adaerr wants to merge 1 commit intojrblevin:masterfrom
Open
Make markdown-mouse-follow-link work when nil#610adaerr wants to merge 1 commit intojrblevin:masterfrom
adaerr wants to merge 1 commit intojrblevin:masterfrom
Conversation
This commit 1. corrects the variable type so it can be toggled in customize-mode 2. defines markdown-mode-mouse-map to an empty map instead of just breaking it 3. deactivates the mouse-face property attribution when no link following wanted. This provides the (presumably) intended behaviour when set to nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR makes markdown-mode behave as intended when markdown-mouse-follow-link (introduced in commit 0fdbf89 as an answer to issue GH-290) is false: no link highlighting through mouse-face, and no link following. No guarantee as to the cleanliness or elegance of the hack, but an improvement over the preceding state. Also corrects a minor bug which prevented the variable from being customisable interactively.
In summary this commit
following wanted.
This provides the (presumably) intended behaviour when set to nil.
Thanks for markdown-mode!
cheers, Adrian
Description
Related Issue
Type of Change
Checklist
make test).