Fix file_line bug and migrate to validate_legacy#2
Open
mattock wants to merge 3 commits intojpuskar:1_6_0from
Open
Fix file_line bug and migrate to validate_legacy#2mattock wants to merge 3 commits intojpuskar:1_6_0from
mattock wants to merge 3 commits intojpuskar:1_6_0from
Conversation
Previously the "after" parameter in file_line matches two lines: the real Location entry and one that had been commented out.
Move to validate_legacy and fix issue in httpd configuration
Author
|
@jpuskar : does this PR look reasonable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puppet runs seem to fail because file_line regexp matches two lines - one that is commented out and one that is not.
This PR also moves to using validate_legacy, which requires relatively up-to-date stdlib.