enhance: 调用MethodChannel的方法都返回Future#121
Open
yohom wants to merge 2 commits intojpush:masterfrom
yohom:master
Open
enhance: 调用MethodChannel的方法都返回Future#121yohom wants to merge 2 commits intojpush:masterfrom yohom:master
yohom wants to merge 2 commits intojpush:masterfrom
yohom:master
Conversation
Contributor
|
治标不治本，原生没有 result。 |
Author
|
那原生为什么不调result？ |
Contributor
|
好问题啊，你怎么不问极光的人呢 |
Author
|
那你是极光的人吗 |
Contributor
|
🤣 你怕不是误解了什么。我想表达的意思就是：你的 PR 白 PR 了，因为原生没有 result，你的 future query await 根本保证不了顺序，反而由于没有 result 的原因，所有的 future 都会被阻塞。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目前一部分方法没有使用MethodChannel的返回值，导致所有调用都是异步的，无法使用await保证执行顺序。