Skip to content

Fix proxy error stack trace #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estliberitas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix proxy error stack trace #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ module.exports = function createError (name, parameters, Constructor) {
// Set up the custom properties for this Error object, if specified.
// Create a new stack descriptor that includes the stacks for any errors
// also passed in
function createStackDescriptor (errors, previous) {
function createStackDescriptor (errors, previous, proxy) {
return function () {
var stack = previous.get();
var stack = previous.get.call(proxy);
errors.forEach(function (error) {
stack += '\n';
stack += error.stack;
Expand Down Expand Up @@ -85,7 +85,7 @@ module.exports = function createError (name, parameters, Constructor) {
// descriptor that includes the other error stacks
if (errors.length > 0) {
properties.stack = {
'get' : createStackDescriptor(errors, stackDescriptor)
'get' : createStackDescriptor(errors, stackDescriptor, proxy)
};
}
// Always set the message manually, in case there was a default supplied
Expand Down