QServer metrics: use ISOServer's activeConnections#670
Merged
Conversation
ar
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QServer was producing the metric:
ISOSERVER_CONNECTION_COUNT("jpos.server.connections", "Incoming active connections")with a unit of THREADS (prometheus full name
jpos_server_connections_threads{....})This was actually using ISOServer's
getConnectionCount(),which returns the historical total count (ever increasing, unlessresetCounters()is explicitly called by someone) and not the count of currently active connextions.The active connection count is both more useful and matches the HELP description of "Incoming active connections".
Also, the suffix/units of
THREADSwasn't conveying useful info, and would leak implementation details.We noticed that
ChannelAdaptoris usingBaseUnits.SESSIONS.This PR attempts to fix both issues:
_sessionssuffix, to align it withChannelAdaptorsemantics.An example:
NOTE: some current Grafana dashboards may need to be adapted to the new name.