Add protected method to connect channel to streams#572
Open
Add protected method to connect channel to streams#572
Conversation
Member
|
It would be nice to have this |
These methods can be overridden by subclasses of existing channels to write to/read from streams, for example, to replay some captured stream, or just to do some tests based on ByteArrayInputStream. Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
e6272a3 to
986b144
Compare
Contributor
Author
|
Sorry, I had written a couple of tests, but somehow the test class got stashed and I didn't notice. I don't think it is a good idea to add the Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods can be overridden by subclasses of existing channels to write to/read from streams,
for example, to replay some captured stream,
or just to do some tests based on ByteArrayInputStream.
Sometimes, we may want to use the existing channels,
but not necessarily to connect them to a TCP/IP endpoint,
for instance, we may want to input data from a file directly as an input of the channel.
Here, there is an example I'm using to read XML messages from a file or standard input: